Ildar Absalyamov has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes ......................................................................
Patch Set 28: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2025/28/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java: PS28, Line 198: component = secondaryIndex : .createBulkLoadTarget(primaryIndex.getDiskComponents().get(componentPos).getComponentId()); : int numTuples = getNumDeletedTuples(componentPos); : componentBulkLoader = component.createBulkLoader(1.0f, false, numTuples, false, true, true); Do we need to have an explicit reference to the bulkloaded component here? Can't we instead call secondaryIndex.createBulkLoader(1.0f, false, numTuples, primaryIndex.getDiskComponents().get(componentPos).getComponentId()) to get secondary disk compoennt bulkloader? That way we avoid smearing callback logic between LSMIndexDiskComponentBulkLoader.end() and activateComponents() here (I don't think this method would be needed at all in this case) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 28 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
