Change in asterixdb[master]: [NO ISSUE][HYR] Support modifying Tracer categories after init

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2105

Change subject: [NO ISSUE][HYR] Support modifying Tracer categories after init
......................................................................

[NO ISSUE][HYR] Support modifying Tracer categories after init

Change-Id: Id209ade0cd20022ad9ae2c9d0c49689081f112a7
---
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/trace/TraceTest.java
3 files changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/2105/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
 
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
index 4f1c2b9..908dc1c 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/ITracer.java
@@ -63,6 +63,11 @@
         }
 
         @Override
+        public void setCategories(String... categories) {
+            // nothing to do here
+        }
+
+        @Override
         public boolean isEnabled(long cat) {
             return false;
         }
@@ -92,6 +97,8 @@
 
     ITraceCategoryRegistry getRegistry();
 
+    void setCategories(String... categories);
+
     boolean isEnabled(long cat);
 
     long durationB(String name, long cat, String args);
diff --git 
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
 
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
index 72a9989..4c6f234 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java
@@ -57,6 +57,10 @@
 
     public Tracer(String name, String[] categories, TraceCategoryRegistry 
registry) {
         this(name, ITraceCategoryRegistry.CATEGORIES_ALL, registry);
+        setCategories(categories);
+    }
+
+    public void setCategories(String... categories) {
         LOGGER.info("Set categories for Tracer " + this.traceLog.getName() + " 
to " + Arrays.toString(categories));
         this.categories = getRegistry().get(categories);
     }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/trace/TraceTest.java
 
b/hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/trace/TraceTest.java
index 4b36013..02bf41c 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/trace/TraceTest.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-util/src/test/java/org/apache/hyracks/util/trace/TraceTest.java
@@ -74,5 +74,17 @@
         for (String line : lines) {
             Assert.assertFalse(validate(line).get("cat").equals("CAT3"));
         }
+        tracer.setCategories("CAT1", "CAT3");
+        os.reset();
+
+        tracer.instant("test1", cat1, ITracer.Scope.p, null);
+        tracer.instant("test2", cat2, ITracer.Scope.p, null);
+        tracer.instant("test3", cat3, ITracer.Scope.p, null);
+
+        handler.flush();
+        lines = os.toString().split("\n");
+        for (String line : lines) {
+            Assert.assertFalse(validate(line).get("cat").equals("CAT2"));
+        }
     }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2105
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id209ade0cd20022ad9ae2c9d0c49689081f112a7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>