Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-1954][STO][RT] Add Index Drop Options ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2121/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/api/RPCInterface.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/api/RPCInterface.java: PS2, Line 97: } catch (InterruptedException e) { : // try to wait again with a timeout : wait(RESPONSE_TIMEOUT_ON_INTERRUPT); : Thread.currentThread().interrupt(); : if (pending) { : throw e; : } : } I think we should only do this selectively for certain operations, and probably the operation should specify the timeout (which probably should apply in all cases, not just interrupt?) -- To view, visit https://asterix-gerrit.ics.uci.edu/2121 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6f8fa52489bbe64d2f48c5c3d0a07be60f30b1b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
