Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][RT][IDX] Simplify index.createAccessor() ......................................................................
Patch Set 6: (2 comments) @Mike.B: thanks! https://asterix-gerrit.ics.uci.edu/#/c/2120/6/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessParameters.java: PS6, Line 42: Map > I would rename getParametersMap -> getParameters Sure. PS6, Line 42: Map<String, Object> getParametersMap(); > Not exposing as a map could be painful if you need to process all of the pa This also makes sense. Then, I think we can keep the original method. How's your thought? @Till and @Abdullah? -- To view, visit https://asterix-gerrit.ics.uci.edu/2120 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae015c342e830c81d666428447b595280139740e Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
