Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2152][FUN][COMP] Enable specifying computation 
location
......................................................................


Patch Set 12:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2114/12/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties
File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties:

PS12, Line 121: Invalid computation location
> Since I added an additional compiler option for specifying the computing lo
Yes, but it might be nice to report the invalid location if one is invalid.


https://asterix-gerrit.ics.uci.edu/#/c/2114/12/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AssignPOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/AssignPOperator.java:

PS12, Line 118: setLocationConstraint
> If the node replacement happens before the query compilation, the query wit
But I'm wondering why a location constraint is always needed for an assign 
operator. Why is a cardinality constraint not good enough?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2114
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7eed5dac03c2f260507e16cf687162d65787bd1
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkk...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to