Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2162][STO] Ensure backward compatibility of 
component id
......................................................................


Patch Set 5:

Just did some manual testing...However, the solution suggested by Mike is not 
working as expected. If we add readObject method to 
LSMBTreeIOOperationCallbackFactory, then it works fine. However, adding 
readObject to AbstractLSMIndexIOOperationCallbackFactory is not working at all, 
since this parent class is newly introduced...

Thus, it seems we have to add a readObject method to all concret factory 
classes?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2147
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie61103b640c37729d43023b92b1245b8e2f4a264
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: No

Reply via email to