Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][TX] Rename Asterix JobId to TxnId ......................................................................
Patch Set 3: (10 comments) https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: PS1, Line 462: txn > txn? Done PS1, Line 465: txn > txn? Done PS1, Line 520: txn > txn? Done PS1, Line 556: abortedTxnId > abortedTxnId? Done https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java: PS1, Line 157: ctx.g > Should we keep this cast? No. Done. https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java: PS1, Line 591: txns > txns? Done https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/DumpTablePrinter.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/DumpTablePrinter.java: PS1, Line 55: txnIdSlotMap > txnIdSlotMap? Done PS1, Line 56: txnIdToJobSlotMa > txnIdToJobSlotMap? Done https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: PS1, Line 162: txn > txn? Done https://asterix-gerrit.ics.uci.edu/#/c/2149/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManagerWithReplication.java: PS1, Line 123: txn > txn? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2149 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0905595a50195b83c1afae5dde88e5502ad21b9f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
