Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2162][STO] Ensure backward compatibility of component id ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2147/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java: PS6, Line 51: protected void checkAndSetIdGeneratorFactory() { what is the motivation to add this and move readObject override to the child? https://asterix-gerrit.ics.uci.edu/#/c/2147/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGeneratorFactory.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentIdGeneratorFactory.java: PS2, Line 35: public ILSMComponentIdGenerator getComponentIdGe > Hmm, not sure I completely follow...In this case, do we need a default UID Yes, we should have this defined. If undefined it is a function of the name, hierarchy, and fields in the class. If we were using instances of this class and it had been possibly in storage previously, we should hardcode that calculated number as our serialVersionUID to enable us to read that data, but as this is unused we can use 1L. Hope this makes sense. :-) -- To view, visit https://asterix-gerrit.ics.uci.edu/2147 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie61103b640c37729d43023b92b1245b8e2f4a264 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
