Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2186][STO] Cache-friendly Bloom Filter ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2201/2/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: PS2, Line 45: : private static final int DEFAULT_BLOOM_FILTER_VERSION = 0; : : private static final int BLOCKED_BLOOM_FILTER_VERSION = 1; > I see. And we are certainly initializing the unused space to 0? And what I Hmm...I'm not using the storage version in the local resource, but just use this trick to handle backward-compatibility (but we can remove this as well, if some recent patches would break storage anyway). BTW, for bloom filter we only use the first few bytes to store meta, and the next bytes are guaranteed to be initialized to 0 by java ByteBuffer. PS2, Line 247: throw HyracksDataException.create(ErrorCode.CANNOT_DEACTIVATE_PINNED_BLOOM_FILTER); > How's it different though, than the normal lifecycle of an index? Deactivat Well, the thing is that an active index is not always used by queries. If it's idle, we can still evict some of pages from buffer cache (this is different from deactive an index entirely). Here the query is typically a large query, with a lot of primary key lookups. Previous, we pin/unpin pages for each primary key check. This change allows pages are only pinned once, and unpinned after the query finishes. -- To view, visit https://asterix-gerrit.ics.uci.edu/2201 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8e0db9b60d5addfaf61ebb372a1bcb2d2d5957 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-HasComments: Yes
