abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE] Jackson parser for JSON format
......................................................................


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2076/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IDataParserFactory.java:

PS7, Line 53:  @throws AsterixException
            :      *             if the parser does not support certain types 
defined in {@value recordType}.
            :      */
> I mean, the Polygon type for instance, in the JSON parser we expect an Obje
Created an issue https://issues.apache.org/jira/browse/ASTERIXDB-2187 for this: 
We can address later.

I think that GeoJSON is not standard JSON and maybe, a special parser 
GeoJsonParser should be added to handle this. However, we can continue the 
discussion outside the scope of this change.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacf9e496dbe2146f5eeeb1506b945991c300a7de
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Xikui Wang <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to