Michael Blow has posted comments on this change. Change subject: [WIP] Delete managix ......................................................................
Patch Set 19: (44 comments) I stopped adding comments for missing spaces between method parameters, but that issue is widespread. https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/TransactionSubsystem.java: PS19, Line 86: if (replicationEnabled) { : this.logManager = new LogManagerWithReplication(this); : } else { : this.logManager = new LogManager(this); : } use ? : form for brevity? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/FaultToleranceStrategyFactory.java: PS19, Line 38: "metadata_only" define constant in ReplicationStrategyFactory and reference? PS19, Line 37: else { : if else if? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java: PS19, Line 56: LISTEN add and use PUBLIC address here PS19, Line 62: keySet().contains containsKey https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/LogMarkerTest.java: PS19, Line 97: // TestHelper.deleteExistingInstanceFiles(); remove if no longer applicable PS19, Line 103: // TestHelper.deleteExistingInstanceFiles(); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dml/DmlTest.java: PS19, Line 62: ,A insert space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java: PS19, Line 1: /* what is changed here? revert? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTest.java: PS19, Line 57: ,T insert space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java: PS19, Line 63: ,T insert space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/optimizer/OptimizerTest.java: PS19, Line 93: ,T insert space PS19, Line 158: //TestHelper.isInPrefixList(only, queryFileShort); remove if no longer applicable PS19, Line 165: //TestHelper.isInPrefixList(ignore, queryFileShort); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTestUtil.java: PS19, Line 53: ,i missing space PS19, Line 53: ,n missing space PS19, Line 57: ,n missing space PS19, Line 73: ,p missing space PS19, Line 76: ,co missing space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java: PS19, Line 57: //TestHelper.isInPrefixList(only, queryFileShort); remove if no longer applicable PS19, Line 64: //TestHelper.isInPrefixList(ignore, queryFileShort); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/DiskIsFullTest.java: PS19, Line 90: // TestHelper.deleteExistingInstanceFiles(); remove if no longer applicable PS19, Line 103: // TestHelper.deleteExistingInstanceFiles(); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/MigrateStorageResourcesTaskTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/storage/MigrateStorageResourcesTaskTest.java: PS19, Line 64: ,D missing space PS19, Line 85: ,D missing space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/txn/RecoveryManagerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/txn/RecoveryManagerTest.java: PS19, Line 53: ," missing space PS19, Line 54: ,3 missing space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-app/src/test/resources/runtimets/data/big_object_20M.adm File asterixdb/asterix-app/src/test/resources/runtimets/data/big_object_20M.adm: PS19, Line 1: { "id": 1, "name": "Person One", "hobbies": {{ "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. this should remain generated https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/PropertiesAccessor.java: PS19, Line 76: LOGGER.info("using new-style configuration"); remove (no longer interesting) https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ReplicationProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ReplicationProperties.java: PS19, Line 100: : REPLICATION_TIME_OUT_DEFAULT, : "The time in seconds to timeout when trying to contact a replica, before assuming it is dead"), : : REPLICATION_ENABLED(BOOLEAN, false, "Whether or not data replication is enabled"), : REPLICATION_FACTOR(INTEGER, 3, "Number of node controller faults to tolerate with replication"), : REPLICATION_STRATEGY(STRING, "chained_declustering", "Replication strategy to choose"), : REPLICATION_PORT(INTEGER, 2000, "port on which to run replication related communications"),; : : private final IOptionType type; : private final Object defaultValue; : private final String description; : : Option(IOptionType type, Object defaultValue, String description) { : this.type = type; : this.defaultValue = defaultValue; : this.description = description; : } : : @Override : public Section section() { : return Section.COMMON; : } : : @Override : public String description() { : return description; : } : : @Override : public IOptionType type() { : return type; : } : : @Override : public Object defaultValue() { : return defaultValue; : } : : @Override : public Object get(IApplicationConfig config) { : switch (this) { : case REPLICATION_TIMEOUT: : return REPLICATION_TIME_OUT_DEFAULT; : default: : return config.getStatic(this); : } : } : } move back to top of class https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SplitsAndConstraintsUtil.java: Line 65: } catch (MetadataException me) { > CRITICAL SonarQube violation: can we add me as a cause to the new exception? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java: PS19, Line 157: ) include exception https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AbstractExecutionIT.java: PS19, Line 54: StringUtils : .join joinPath PS19, Line 83: /* FileUtils : .copyFile( : new File(StringUtils.join(new String[] { "src", "test", "resources", "integrationts", : "asterix-configuration.xml" }, File.separator)), : new File(NCServiceExecutionIT.ASTERIX_APP_DIR + "/conf/asterix-configuration.xml"));*/ remove if no longer applicable PS19, Line 97: //AsterixLifecycleIT.setUp(); remove if no longer applicable PS19, Line 111: // FileUtils.copyDirectoryStructure(new File(FileUtil.joinPath("target", "data")), : // new File(NCServiceExecutionIT.ASTERIX_APP_DIR : // + "/clusters/local/working_dir/target/data/csv")); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AsterixInstallerIntegrationUtil.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/AsterixInstallerIntegrationUtil.java: PS19, Line 136: //public static void transformIntoRequiredState(AsterixInstance.State state) throws Exception { : //} remove if no longer applicable PS19, Line 152: // cmdHandler.processCommand(command.trim().split(" ")); remove if no longer applicable https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java File asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java: PS19, Line 81: ,O missing space https://asterix-gerrit.ics.uci.edu/#/c/2155/19/asterixdb/asterix-server/src/test/resources/ReplicationIT/cc.conf File asterixdb/asterix-server/src/test/resources/ReplicationIT/cc.conf: PS19, Line 19: txn.log.dir=../asterix-server/target/tmp/asterix_nc1/txnlog what is the root dir here? why do we need to ../asterix-server? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: PS19, Line 287: : : : : : : : : why removed? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: PS19, Line 43: Option.REPLICATION_LISTEN_ADDRESS there should be a different LISTEN and PUBLIC address for REPLICATION, and not be mixed here. PS19, Line 258: public enum Option implements IOption { : ADDRESS(STRING, InetAddress.getLoopbackAddress().getHostAddress()), : PUBLIC_ADDRESS(STRING, ADDRESS), : CLUSTER_LISTEN_ADDRESS(STRING, ADDRESS), : CLUSTER_LISTEN_PORT(INTEGER, 0), : NCSERVICE_ADDRESS(STRING, PUBLIC_ADDRESS), : NCSERVICE_PORT(INTEGER, 9090), : CLUSTER_ADDRESS(STRING, (String) null), : CLUSTER_PORT(INTEGER, 1099), : CLUSTER_PUBLIC_ADDRESS(STRING, PUBLIC_ADDRESS), : CLUSTER_PUBLIC_PORT(INTEGER, CLUSTER_LISTEN_PORT), : NODE_ID(STRING, (String) null), : DATA_LISTEN_ADDRESS(STRING, ADDRESS), : DATA_LISTEN_PORT(INTEGER, 0), : DATA_PUBLIC_ADDRESS(STRING, PUBLIC_ADDRESS), : DATA_PUBLIC_PORT(INTEGER, DATA_LISTEN_PORT), : RESULT_LISTEN_ADDRESS(STRING, ADDRESS), : RESULT_LISTEN_PORT(INTEGER, 0), : RESULT_PUBLIC_ADDRESS(STRING, PUBLIC_ADDRESS), : RESULT_PUBLIC_PORT(INTEGER, RESULT_LISTEN_PORT), : MESSAGING_LISTEN_ADDRESS(STRING, ADDRESS), : MESSAGING_LISTEN_PORT(INTEGER, 0), : MESSAGING_PUBLIC_ADDRESS(STRING, PUBLIC_ADDRESS), : MESSAGING_PUBLIC_PORT(INTEGER, MESSAGING_LISTEN_PORT), : REPLICATION_LISTEN_ADDRESS(STRING, PUBLIC_ADDRESS), : REPLICATION_LISTEN_PORT(INTEGER, 2000), : CLUSTER_CONNECT_RETRIES(INTEGER, 5), : IODEVICES( : STRING_ARRAY, : appConfig -> new String[] { : FileUtil.joinPath(appConfig.getString(ControllerConfig.Option.DEFAULT_DIR), "iodevice") }, : "<value of " + ControllerConfig.Option.DEFAULT_DIR.cmdline() + ">/iodevice"), : NET_THREAD_COUNT(INTEGER, 1), : NET_BUFFER_COUNT(INTEGER, 1), : RESULT_TTL(LONG, 86400000L), : RESULT_SWEEP_THRESHOLD(LONG, 60000L), : RESULT_MANAGER_MEMORY(INTEGER_BYTE_UNIT, -1), : @SuppressWarnings("RedundantCast") // not redundant- false positive from IDEA : APP_CLASS(STRING, (String) null), : NCSERVICE_PID(INTEGER, -1), : COMMAND(STRING, "hyracksnc"), : JVM_ARGS(STRING, (String) null), : TRACE_CATEGORIES(STRING_ARRAY, new String[0]); : : private final IOptionType parser; : private final String defaultValueDescription; : private Object defaultValue; : : <T> Option(IOptionType<T> parser, Option defaultOption) { : this.parser = parser; : this.defaultValue = defaultOption; : defaultValueDescription = null; : } : : <T> Option(IOptionType<T> parser, T defaultValue) { : this.parser = parser; : this.defaultValue = defaultValue; : defaultValueDescription = null; : } : : <T> Option(IOptionType<T> parser, Function<IApplicationConfig, T> defaultValue, : String defaultValueDescription) { : this.parser = parser; : this.defaultValue = defaultValue; : this.defaultValueDescription = defaultValueDescription; : } : : @Override : public Section section() { : switch (this) { : case NODE_ID: : return Section.LOCALNC; : default: : return Section.NC; : } : } : : @Override : @SuppressWarnings("squid:MethodCyclomaticComplexity") : public String description() { : switch (this) { : case ADDRESS: : return "Default IP Address to bind listeners on this NC. All services will bind on this address " : + "unless a service-specific listen address is supplied."; : case CLUSTER_LISTEN_ADDRESS: : return "IP Address to bind cluster listener on this NC"; : case PUBLIC_ADDRESS: : return "Default public address that other processes should use to contact this NC. All services " : + "will advertise this address unless a service-specific public address is supplied."; : case NCSERVICE_ADDRESS: : return "Address the CC should use to contact the NCService associated with this NC"; : case NCSERVICE_PORT: : return "Port the CC should use to contact the NCService associated with this NC (-1 to not use " + : "NCService to start this NC)"; : case CLUSTER_ADDRESS: : return "Cluster Controller address (required unless specified in config file)"; : case CLUSTER_PORT: : return "Cluster Controller port"; : case CLUSTER_LISTEN_PORT: : return "IP port to bind cluster listener"; : case CLUSTER_PUBLIC_ADDRESS: : return "Public IP Address to announce cluster listener"; : case CLUSTER_PUBLIC_PORT: : return "Public IP port to announce cluster listener"; : case NODE_ID: : return "Logical name of node controller unique within the cluster (required unless specified in " : + "config file)"; : case DATA_LISTEN_ADDRESS: : return "IP Address to bind data listener"; : case DATA_LISTEN_PORT: : return "IP port to bind data listener"; : case DATA_PUBLIC_ADDRESS: : return "Public IP Address to announce data listener"; : case DATA_PUBLIC_PORT: : return "Public IP port to announce data listener"; : case RESULT_LISTEN_ADDRESS: : return "IP Address to bind dataset result distribution listener"; : case RESULT_LISTEN_PORT: : return "IP port to bind dataset result distribution listener"; : case RESULT_PUBLIC_ADDRESS: : return "Public IP Address to announce dataset result distribution listener"; : case RESULT_PUBLIC_PORT: : return "Public IP port to announce dataset result distribution listener"; : case MESSAGING_LISTEN_ADDRESS: : return "IP Address to bind messaging listener"; : case MESSAGING_LISTEN_PORT: : return "IP port to bind messaging listener"; : case MESSAGING_PUBLIC_ADDRESS: : return "Public IP Address to announce messaging listener"; : case MESSAGING_PUBLIC_PORT: : return "Public IP port to announce messaging listener"; : case REPLICATION_LISTEN_ADDRESS: : return "Replication bind address"; : case REPLICATION_LISTEN_PORT: : return "Port to listen on for replication service"; : case CLUSTER_CONNECT_RETRIES: : return "Number of attempts to retry contacting CC before giving up"; : case IODEVICES: : return "Comma separated list of IO Device mount points"; : case NET_THREAD_COUNT: : return "Number of threads to use for Network I/O"; : case NET_BUFFER_COUNT: : return "Number of network buffers per input/output channel"; : case RESULT_TTL: : return "Limits the amount of time results for asynchronous jobs should be retained by the system " : + "in milliseconds"; : case RESULT_SWEEP_THRESHOLD: : return "The duration within which an instance of the result cleanup should be invoked in " : + "milliseconds"; : case RESULT_MANAGER_MEMORY: : return "Memory usable for result caching at this Node Controller in bytes"; : case APP_CLASS: : return "Application NC Main Class"; : case NCSERVICE_PID: : return "PID of the NCService which launched this NCDriver"; : case COMMAND: : return "Command NCService should invoke to start the NCDriver"; : case JVM_ARGS: : return "JVM args to pass to the NCDriver"; : case TRACE_CATEGORIES: : return "Categories for tracing"; : default: : throw new IllegalStateException("NYI: " + this); : } : } : : @Override : public IOptionType type() { : return parser; : } : : @Override : public Object defaultValue() { : return defaultValue; : } : : public void setDefaultValue(Object defaultValue) { : this.defaultValue = defaultValue; : } : : @Override : public String usageDefaultOverride(IApplicationConfig accessor, Function<IOption, String> optionPrinter) { : return defaultValueDescription; : } : : } : : ; : relocate back to top? https://asterix-gerrit.ics.uci.edu/#/c/2155/19/hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java File hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java: PS19, Line 44: cList.add("-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005"); comment out -- To view, visit https://asterix-gerrit.ics.uci.edu/2155 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c710b6ec870bedd49dd46b74ed96a3665670e9b Gerrit-PatchSet: 19 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
