Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2198][REPL] Introduce Dynamic Replica Placement ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2215/4/asterixdb/asterix-app/src/test/resources/runtimets/results/replication/metadata_failover/metadata_failover.8.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/replication/metadata_failover/metadata_failover.8.adm: PS4, Line 2: asterix_nc2 > let's also test the state after the metadata node change Changed the test call to poll to wait until metadata node change is reflected in the cluster state and updated the expected result to asterix_nc. https://asterix-gerrit.ics.uci.edu/#/c/2215/4/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DeleteFileTask.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DeleteFileTask.java: PS4, Line 54: exists > warn if the file does not exist Done https://asterix-gerrit.ics.uci.edu/#/c/2215/4/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/recovery/ReplicaFilesSynchronizer.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/recovery/ReplicaFilesSynchronizer.java: PS4, Line 56: replicaMissingFiles > replicaMissingFiles Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2215 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11f82efcad29d2c37324fe9d3c11d872b0348f49 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes