Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2181][FUN] Check whether a function is usable at 
creation
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2242/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

Line 1705:             metadataProvider.setDefaultDataverse(activeDataverse);
Let's put this into the finally block, so the default dataverse gets restored 
even if there's an error during function check.


https://asterix-gerrit.ics.uci.edu/#/c/2242/2/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 6386
Some tests were deleted. Why are they no longer necessary? Are all of them 
replaced by the new tests?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2242
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I262b8cfd29117c18f452973fed147696b83f1249
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to