Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2182][ING] Use JSON-like syntax for feed configuration ......................................................................
Patch Set 9: (2 comments) Addressed comments. Yes for the external data and load. :) https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/visitor/FormatPrintVisitor.java: Line 758: printConfiguration(cfs.getFeedConfigurations()); > we should fix this. Fixed. I thought this is for debugging purpose only. It makes perfect sense to make them consistent with the input so we could use it without further conversion. I am thinking maybe we can add a visitor test to make sure the query and visited result are consistent, but the output order of JSON object is different, so the naive string comparison can't be used in this case... https://asterix-gerrit.ics.uci.edu/#/c/2209/9/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java: PS9, Line 110: if (adapterName == null) { : throw new AlgebricksException("cannot find adatper name"); : } > I wonder if the generic adapter can be chosen if this is not passed. I think the answer is no... Even if we return a generic adapter, what does the adapter do (socket, file, twitter)? -- To view, visit https://asterix-gerrit.ics.uci.edu/2209 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dfb0fdf74d28ae0c45dafcf6babb624bd8b2149 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
