Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2180][FUN] Prevent dropping of entities used by functions ......................................................................
Patch Set 12: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2253/12/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 1711: Set<CallExpr> functionCalls = FunctionUtil.getFunctionCalls(rewriterFactory.createQueryRewriter(), I meant to extract the whole for loop into a separate helper method in FunctionUtil. Call it something like FunctionUtil.retrieveUsedDependencies() which would take an expression and return List<List<List<String>>> of dependencies -- To view, visit https://asterix-gerrit.ics.uci.edu/2253 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f08ff150dfd57432b88381c507814ddb57bd67b Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
