Shiva Jahangiri has posted comments on this change. Change subject: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested partitioning keys ......................................................................
Patch Set 5: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2246/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java: PS5, Line 180: if (partitioningKey.size() != fieldExpr.size()) { : continue; : } : for (int j = 0; j < partitioningKey.size(); j++) { : if (!partitioningKey.get(j).equals(fieldExpr.get(j))) { : break; : } : if (j == partitioningKey.size() - 1) { : return i; : } : } Doesn't partitioningKey.equals(fieldExpr) work?(https://stackoverflow.com/questions/1075656/simple-way-to-find-if-two-different-lists-contain-exactly-the-same-elements) -- To view, visit https://asterix-gerrit.ics.uci.edu/2246 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I874c1fd15719b6bdeb7b0913fbafc04a58d32ed4 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Shiva Jahangiri <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
