Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2243][STO] Fix BloomFilter size estimation ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2285/1/hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks-fullstack/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: PS1, Line 275: numElements > Let's change this variable name to be something like expectedNumElements, i Sounds good to me. But what about estimatedNumElements to reflect this is an estimation? -- To view, visit https://asterix-gerrit.ics.uci.edu/2285 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4054797d969efcfceb86f91b5321d34480e25c3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-HasComments: Yes
