Ian Maxon has posted comments on this change. Change subject: [NO ISSUE][RT] Add test cases for runtime failures ......................................................................
Patch Set 2: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2290/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/FailOnInitializeDeInitializeOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/FailOnInitializeDeInitializeOperatorDescriptor.java: PS2, Line 31: lic class FailOnInitializeDeInitializeOperatorDescriptor extends AbstractSingleActivityOperatorDescriptor { > I wanted a shared error message for failures in the initialize method and i ah okay that's fine, i see how you're using it in the test more clearly now https://asterix-gerrit.ics.uci.edu/#/c/2290/2/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/NoOpOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/NoOpOperatorDescriptor.java: PS2, Line 31: c class NoOpOperatorDescriptor extends AbstractSingleActivityOperatorDescriptor > The error message is not here because this operator doesn't cause or throw oic -- To view, visit https://asterix-gerrit.ics.uci.edu/2290 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If26ade138b003349cfd9619188bd9129ecd1034a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
