Ildar Absalyamov has posted comments on this change. Change subject: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested partitioning keys ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2246/6/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java: PS6, Line 185: IS_MOVABLE Since we here anyways, can you change that to refernce OperatorPropertiesUtil.MOVABLE instead? PS6, Line 357: fieldPath.add(0, fldName); Use LinkedList.addFirst() instead. add(0,x) is O(n) for ArrayList. PS6, Line 358: if (!AnalysisUtil.isAccessToFieldRecord(accessFun.getArguments().get(0).getValue())) { : e0 = accessFun.getArguments().get(0).getValue(); : break; : } Not sure why you need this additional check. It's the same condition as in the while loop. accessFun content is your e0 -- To view, visit https://asterix-gerrit.ics.uci.edu/2246 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I874c1fd15719b6bdeb7b0913fbafc04a58d32ed4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Shiva Jahangiri <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
