Michael Blow has posted comments on this change.

Change subject: [NO ISSUE] More multi-CC support, ConfigManager updates
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2344/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobId.java:

Line 83:         return "JID:[" + getCcId() + "]" + getIdOnly();
> space
space where?


PS1, Line 88: str = str.substring(4);
            :             return new JobId(Long.parseLong(str));
> do we need to adjust this to the new toString?
yep, thanks


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2344
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff60887bf71ce3f3ed7201afd9499612bfc83485
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org>
Gerrit-HasComments: Yes

Reply via email to