Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2282][HTTP] Revive HTTP server on unexpected channel drops ......................................................................
Patch Set 4: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/2382/4/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: Line 143: LOGGER.log(Level.ERROR, "Failure stopping recovery thread"); include which http server here PS4, Line 240: The Http server change to {}, pass 'this', and define a toString on HttpServer to identify which http server this is (i.e include port) PS4, Line 253: The Http server change to {}, pass 'this', and define a toString on HttpServer to identify which http server this is (i.e include port) PS4, Line 266: true !Thread.currentThread().isInterrupted(), otherwise this is going to spin on interrupt Line 273: LOGGER.log(Level.WARN, "Interrupted while attempting to revive server channel", e); include 'this', and define a toString on HttpServer to identify which http server this is (i.e include port) PS4, Line 278: LOGGER.log(Level.WARN, "Failed server recovery attempt", th); : LOGGER.log(Level.WARN, "Sleeping for 5s before starting the next attempt"); combine into one log Line 284: LOGGER.log(Level.WARN, "Interrupted while attempting to revive server channel", e); include 'this', and define a toString on HttpServer to identify which http server this is (i.e include port) -- To view, visit https://asterix-gerrit.ics.uci.edu/2382 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7da75a9e34795c94518aca243b4cef387221d8fd Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
