Wail Alkowaileet has posted comments on this change. Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct ......................................................................
Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2322/7/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/condition/factor-common-conjunct/factor-common-conjunct.3.query.sqlpp: Line 35 > Can you also add "null" and "missing" value combinations to this test and o Thanks for reviewing :) I included the full truth table for 3 variables in the test and added two more tests. If you have/think other tests cases should be added, please let me know. -- To view, visit https://asterix-gerrit.ics.uci.edu/2322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com> Gerrit-HasComments: Yes
