Taewoo Kim has submitted this change and it was merged. Change subject: [NO ISSUE][RT] no latching on an inverted list during merge ......................................................................
[NO ISSUE][RT] no latching on an inverted list during merge - user-model changes: no - storage format changes: no - interface changes: no Details: - Do not conduct a latching on an inverted list during a disk component merge of an inverted index since a disk component is immutable. Change-Id: I266135596bbd5158d5fcf5ce3d1735d407be6f0f Reviewed-on: https://asterix-gerrit.ics.uci.edu/2444 Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Contrib: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Reviewed-by: abdullah alamoudi <bamou...@gmail.com> --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Anon. E. Moose #1000171: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java index ca0f40b..b033b99 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListScanCursor.java @@ -30,7 +30,7 @@ import org.apache.hyracks.storage.common.file.BufferedFileHandle; /** - * A simple scan cursor that only reads a frame by frame from the inverted list. This cursor does not + * A simple scan cursor that only reads a frame by frame from the inverted list on disk. This cursor does not * conduct a binary search. It only supports the scan operation. The main purpose of this cursor is * doing a full-scan of an inverted list during a storage-component-merge process. */ @@ -111,14 +111,12 @@ } currentPageId++; page = bufferCache.pin(BufferedFileHandle.getDiskPageId(fileId, currentPageId), false); - page.acquireReadLatch(); pinned = true; } @Override public void unloadPages() throws HyracksDataException { if (pinned) { - page.releaseReadLatch(); bufferCache.unpin(page); pinned = false; } -- To view, visit https://asterix-gerrit.ics.uci.edu/2444 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I266135596bbd5158d5fcf5ce3d1735d407be6f0f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
