Wail Alkowaileet has posted comments on this change. Change subject: [ASTERIXDB-2357] ADMParser Improvements ......................................................................
Patch Set 6: Code-Review+1 (1 comment) I have only one comment. https://asterix-gerrit.ics.uci.edu/#/c/2573/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/RecordBuilder.java: PS6, Line 313: fieldName2Id Can we use recType.getFieldIndex? -- To view, visit https://asterix-gerrit.ics.uci.edu/2573 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I106b58e79746b0a6f3d8b79473202653341a7009 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
