Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2619/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java: PS1, Line 101: upsertDeployedJobSpec > Is this a name that has been discussed before? I personally think upsert ha The reason I went with upsert is because this is technically working with an upsert semantic, i.e. if the job spec currently doesn't exist, it is inserted, otherwise it is replaced. https://asterix-gerrit.ics.uci.edu/#/c/2619/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DeployJobSpecWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DeployJobSpecWork.java: PS1, Line 42: checkForDuplicate > You can use upsert here if you want. :) Done https://asterix-gerrit.ics.uci.edu/#/c/2619/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DeployJobSpecWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DeployJobSpecWork.java: Line 40: private final boolean checkForDuplicate; > same as cc Done https://asterix-gerrit.ics.uci.edu/#/c/2619/1/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DeployedJobSpecsTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DeployedJobSpecsTest.java: Line 202: > is there a test case for the unhappy path? add a deploy job with the same i Actually there is no such "unhappy" path. the deploy function doesn't take an id, and the upsert function can be called with the same id as many times as a users wants. -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
