Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2399][SQL][FUN] Rename COLL_ aggregate functions ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2691/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/FunctionMapUtil.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/FunctionMapUtil.java: Line 122: if (isCoreAggregateFunction(fs)) { isCoreAggregateFunction() now takes a substring and then immediately throws it away. Not ideal. Can we change this method to just call getInternalCoreAggregateFunctionName() and if it's not null then call BuiltinFunctions.getAggregateFunction() and then create new FunctionSignature. so inline isCoreAggregateFunction here, because this code is the only user of that function. -- To view, visit https://asterix-gerrit.ics.uci.edu/2691 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c103dbe7fa42bf5c4e2bfa53592b2041084aa8f Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
