Hello Anon. E. Moose #1000171, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/2730
to look at the new patch set (#2).
Change subject: [ASTERIXDB-2402,ASTERIXDB-2404,ASTERIXDB-2405][COMP] Fix
Asterix compiler issues
......................................................................
[ASTERIXDB-2402,ASTERIXDB-2404,ASTERIXDB-2405][COMP] Fix Asterix compiler issues
This change fixes the following compilation issues
1. AccessMethodUtils.findLOJIsMissingFuncInGroupBy()
looks for the not(is-missing($VAR)) pattern
in a group by, but fails to detect it if it is part of
an and, e.g. and(not(is-missing($VAR1)),not(is-missing($VAR2)))
2. AbstractGroupingProperty.reduceGroupingColumns()
mishandles empty heads for functional dependencies
If a group by uses variable $VAR,
and there is a functional dependency of the form:
[] -> $VAR
reduceGroupingColumns() will eliminate $VAR from the group by.
3. Currently, we only have two delegates:
commit()
and the BAD delegate, notify-brokers()
They should both be considered by IntroduceJoinAccessMethodUtil
as starting points for optimization.
Change-Id: Id2a6a16a5342e30c246b62a3b5ddbf7249a0d0cc
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/AbstractGroupingProperty.java
3 files changed, 33 insertions(+), 19 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/30/2730/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/2730
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2a6a16a5342e30c246b62a3b5ddbf7249a0d0cc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
