Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2402][COMP] Allow AND for IsMissing in Groupby ......................................................................
Patch Set 2: (2 comments) I'll upload a new code change. https://asterix-gerrit.ics.uci.edu/#/c/2735/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 1505: //find IS_MISSING function of which argument has the nullPlaceholder variable in the nested plan of groupby. > Do we check that the variable inside is_missing() is the one we need? I cou I'm going to add a check to make sure the variable corresponds to an assignment of true. VAR1 and VAR2 are both usable since they are from the same inlined plan, so for now the code will just choose VAR1. https://asterix-gerrit.ics.uci.edu/#/c/2735/2/asterixdb/asterix-app/src/test/resources/optimizerts/queries/ASTERIXDB-2402.sqlpp File asterixdb/asterix-app/src/test/resources/optimizerts/queries/ASTERIXDB-2402.sqlpp: Line 102: insert into channels.EmergenciesNearMeChannelResults as a ( > can we simplify the statement here? Is the insert necessary or a simpler q This is the simplest repro that I've found. I'm not sure exactly what combination of things leads to this situation. I think it's good to have this full statement anyway, as this is the type of statement that we need to make sure is able to compile for BAD -- To view, visit https://asterix-gerrit.ics.uci.edu/2735 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9547fba5e4ba02226b5b2c2504080b091d3b8d5e Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
