Murtadha Hubail has posted comments on this change. Change subject: Introducing Data Replication To AsterixDB ......................................................................
Patch Set 6: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/338/6/asterix-common/src/main/java/org/apache/asterix/common/replication/ReplicaEvent.java File asterix-common/src/main/java/org/apache/asterix/common/replication/ReplicaEvent.java: Line 25: SPLIT, > better be FAIL Done Line 26: MERGE, > JOIN Done https://asterix-gerrit.ics.uci.edu/#/c/338/6/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java File asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationChannel.java: Line 105: lsmComponentsFilesSyncQ = new LinkedBlockingQueue<LSMComponentLSNSyncTask>(); > Renaming: lsmComponentRemoteLSN2LocalLSNMappingTaskQ Done Line 106: lsmComponents = new ConcurrentHashMap<String, LSMComponentProperties>(); > lsmComponentId2PropertiesMap Done Line 107: remoteLogsMap = new ConcurrentHashMap<Long, RemoteLogMapping>(); > localLSN2RemoteLSNMap Done Line 108: lsmComponentsSyncService = new LSMComponentsSyncService(); > lsmComponentLSNMappingService Done Line 275: List<IIndex> openIndexList = indexLifecycleManager.getOpenIndexes(); > Let's have a method in datasetlifecyclemanager::getOpenIndex(resourceId or Done, and adapted this method to the new API. Line 620: > Let's explain the situation when this situation can happen. Done https://asterix-gerrit.ics.uci.edu/#/c/338/6/asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java File asterix-replication/src/main/java/org/apache/asterix/replication/management/ReplicationManager.java: Line 738: public void requestFlushLaggingReplicaIndexes(long nonSharpCheckpointTargetLSN) throws IOException { > Please describe protocols which is not obvious. Done. I have also added documentation to all methods in the interface and private ones. Line 823: > this is recovery method.? Done Line 875: > recovery method? Done Line 900: > recovery method? Done https://asterix-gerrit.ics.uci.edu/#/c/338/6/asterix-replication/src/main/java/org/apache/asterix/replication/storage/ReplicaResourcesManager.java File asterix-replication/src/main/java/org/apache/asterix/replication/storage/ReplicaResourcesManager.java: Line 369: public HashMap<Long, Long> getReplicaIndexLSNMap(String indexPath) throws IOException { > accessing IndexLSNMap should be synchronized between all possible readers a Done -- To view, visit https://asterix-gerrit.ics.uci.edu/338 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I729fdd1144dbc9ff039b4bc414494860d7553810 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
