Young-Seok Kim has posted comments on this change. Change subject: Introducing Data Replication To AsterixDB ......................................................................
Patch Set 12: (2 comments) Please address comments. Also, please address comment in corresponding hyracks change. https://asterix-gerrit.ics.uci.edu/#/c/338/12/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 401: private boolean memoryAllocated; This should be AtomicBoolean since reader and updater will access the variable concurrently and we don't want to have any side effect by doing so. https://asterix-gerrit.ics.uci.edu/#/c/338/12/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 492: * >>>>>>> master let's remove ">>>>>>> master" -- To view, visit https://asterix-gerrit.ics.uci.edu/338 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I729fdd1144dbc9ff039b4bc414494860d7553810 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
