Murtadha Hubail has posted comments on this change. Change subject: Add method to check state of buffer cache ......................................................................
Patch Set 1: Code-Review+2 (4 comments) Just few suggestions :) https://asterix-gerrit.ics.uci.edu/#/c/497/1/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: Line 495: boolean valid = true; remove Line 501: valid = false; return false Line 505: return valid; return true https://asterix-gerrit.ics.uci.edu/#/c/497/1/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IBufferCacheInternal.java File hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/IBufferCacheInternal.java: Line 22: boolean validateEmpty(); isEmptry -- To view, visit https://asterix-gerrit.ics.uci.edu/497 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba8 Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
