Young-Seok Kim has posted comments on this change. Change subject: Make LSM bulkload append-only and write-once. ......................................................................
Patch Set 41: (14 comments) to be continued https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java File hyracks/hyracks-storage-am-bloomfilter/src/main/java/org/apache/hyracks/storage/am/bloomfilter/impls/BloomFilter.java: Line 230: //readBloomFilterMetaData(); remove! Line 253: private void persistBloomFilterMetaData() throws HyracksDataException { Let's give a meaningful name. https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: Line 55: protected boolean hasEverBeenActivated = false; could you add comment for the purpose of having hasEverBeenActivated flag from isActive? Line 181: } Let's just use FreePageManager.appendOnlyMode() Line 369: continue; remove continue? Line 412: } remove else{ https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java: Line 618: //component.getBuddyBTree().create(false); remove comments Line 623: // component.getBuddyBTree().activate(); remove comments https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java: Line 441: //System.out.println("Flushing component:"+ component.getBTree().hashCode()); remove comment Line 587: // // Flush the bloom filter first. clean up https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: Line 75: //System.out.println("Searching disk component: "+btreeAccessors[i].hashCode()); remove! https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentFilterManager.java: Line 84: treeMetaManager.setFilterPage(bufferCache.confiscatePage(-2l)); use INVALID_DPID https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java: Line 393: public boolean isVirtual(ICachedPage vp) throws HyracksDataException { remove the interface method https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java File hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java: Line 885: forceFlushDirtyPages(invIndex.getBTree()); Make sure that the inverted list file pages are all flushed. -- To view, visit https://asterix-gerrit.ics.uci.edu/255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 Gerrit-PatchSet: 41 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
