Ian Maxon has posted comments on this change. Change subject: Make LSM bulkload append-only and write-once. ......................................................................
Patch Set 41: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IIndexBulkLoader.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IIndexBulkLoader.java: Line 18: */ > remove carriage return Done https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IMetaDataPageManager.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/api/IMetaDataPageManager.java: Line 1: /* > Wrong license header! Done https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/freepage/LinkedMetaDataPageManager.java: Line 1: /* > Wrong license! Done https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: Line 38: public static int TREE_METADATA_NUM_PAGES = 2; > MINIMAL_PAGE_SIZE_OF_TREE Done Line 55: protected boolean hasEverBeenActivated = false; > could you add comment for the purpose of having hasEverBeenActivated flag f Done Line 181: } > Let's just use FreePageManager.appendOnlyMode() Done(ish) https://asterix-gerrit.ics.uci.edu/#/c/255/41/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java File hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java: Line 969: interiorFrame.insert(mbrTuple, -1); > -1: GREATEAST KEY INDICATOR ... ? Yeah... unfortunately this is a magic number -1 throughout the RTree code. It should be like slotManager.getGreatestKeyIndicator(). :\ -- To view, visit https://asterix-gerrit.ics.uci.edu/255 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fb891b5310252143854a336b591bf3f8cd4ba7 Gerrit-PatchSet: 41 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
