Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1221: - Fixed test regression and improved plans in insert\delete pipeline ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/548/1/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/IMetadataProvider.java: Line 194: public IDataSourceIndex<I, S> findIndex(I indexId, I dataverseName, I datasetName) throws AlgebricksException; Adding this interface seems not necessary. 1. Why findDataSourceIndex is not enough? 2. You can just add that in AqlMetadataProvider. -- To view, visit https://asterix-gerrit.ics.uci.edu/548 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0f213f69802a4019891bcebfc03caba9c7251f Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: release-0.2.17 Gerrit-Owner: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
