Yingyi Bu has posted comments on this change.

Change subject: Fix for ASTERIXDB-1018, ASTERIXDB-1017, ASTERIXDB-1019, 
ASTERIXDB-1020, ASTERIXDB-1029, ASTERIXDB-1030, ASTERIXDB-1034
......................................................................


Patch Set 14:

(4 comments)

Post comments for Till and Steven.

https://asterix-gerrit.ics.uci.edu/#/c/489/14/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File 
asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

Line 244:         boolean leftSubTreeMatched = 
leftSubTree.initFromSubTree(join.getInputs().get(0));
matched --> initialized


https://asterix-gerrit.ics.uci.edu/#/c/489/14/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
File 
asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java:

Line 66: 
Add an abstract example.


Line 351:         // Sets up the nested plan for the grou-by operator.
group


https://asterix-gerrit.ics.uci.edu/#/c/489/14/asterix-app/src/test/resources/optimizerts/queries/udfs/query-ASTERIXDB-1017.aql
File 
asterix-app/src/test/resources/optimizerts/queries/udfs/query-ASTERIXDB-1017.aql:

Line 54:          //and spatial-intersect($dangerzone,$user.location))
add a note to say spatial-intersect is commented out.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/489
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc1f844ac6e06e00da3f1618235b6ce9bfd48e9f
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Ildar Absalyamov <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to