Till Westmann has posted comments on this change. Change subject: Fix for ASTERIXDB-1018, ASTERIXDB-1017, ASTERIXDB-1019, ASTERIXDB-1020, ASTERIXDB-1029, ASTERIXDB-1030, ASTERIXDB-1034 ......................................................................
Patch Set 18: Code-Review+2 (4 comments) Looks good to me (after discussing with Yingyi). Just a few clean-up comments. Feel free to forward the +2 if you decide to address them. https://asterix-gerrit.ics.uci.edu/#/c/489/18//COMMIT_MSG Commit Message: Line 13: result should actually be used in introducejoinaccessmethodrule capitalization? Line 15: in abstractintroduceaccessmethodrule. capitalization? https://asterix-gerrit.ics.uci.edu/#/c/489/18/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 77: // Indentation broken? Is there a way to tell eclipse not to "fix" indentation for certain parts of the code? https://asterix-gerrit.ics.uci.edu/#/c/489/18/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java File asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java: Line 1260: empty line? -- To view, visit https://asterix-gerrit.ics.uci.edu/489 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc1f844ac6e06e00da3f1618235b6ce9bfd48e9f Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
