Murtadha Hubail has posted comments on this change. Change subject: Asterix NCs Fault Tolerance ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/573/2/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java File asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java: Line 70: startGlobalRecovery(); > Why do we return null here, anyway? This is part of the IClusterEventsSubscriber interface. If any of the subscribers requires a certain cluster tasks to be done after it gets an event (e.g. a node joins or leaves), it returns those tasks to the ClusterLifecycleListener to execute them, otherwise the subscriber returns null. In this case, we only need to start a thread to perform global recovery, but we don't need to do any cluster tasks. -- To view, visit https://asterix-gerrit.ics.uci.edu/573 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice26d980912a315fcb3efdd571d6ce88717cfea4 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
