Till Westmann has posted comments on this change.

Change subject: Pass task partition to IPushRuntime
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/589/1/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IPushRuntimeFactory.java
File 
algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IPushRuntimeFactory.java:

Line 28:     public IPushRuntime createPushRuntime(IHyracksTaskContext ctx, int 
partition) throws AlgebricksException, HyracksDataException;
Haven't looked in detail, but I'm wondering if it would be better to add the 
partition to the TaskContext. I think that we do have 1 Task object per 
partition, is that right?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/589
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd566ea97512c1dbd2217befdc2bb8822e77763
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to