Ian Maxon has posted comments on this change. Change subject: Asterix NCs Fault Tolerance ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/573/6/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java: Line 420: ExternalLibraryBootstrap.setUpExternaLibraries(isMetadataNode); We don't end up importing the metadata from the library XML twice when we do this on failover, right? https://asterix-gerrit.ics.uci.edu/#/c/573/6/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java File asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java: Line 335: } catch (Exception e) { Is there something else to do here besides printing the stack maybe? Line 380: } catch (Exception e) { Ditto with above comment. -- To view, visit https://asterix-gerrit.ics.uci.edu/573 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice26d980912a315fcb3efdd571d6ce88717cfea4 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
