Till Westmann has posted comments on this change. Change subject: Support Sending Messages Alongside Frame Data ......................................................................
Patch Set 2: (2 comments) For the first round I've got a few questions at the code level. https://asterix-gerrit.ics.uci.edu/#/c/605/2/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java File asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java: Line 57: ctx.setObject("feedId", feedId); Does anybody read this feedId? If so, "feedId" should probably be a constant. https://asterix-gerrit.ics.uci.edu/#/c/605/2/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java File asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapterFactory.java: Line 86: forwarder.initialize((IHyracksTaskContext) ctx, writer); This cast seems wrong. Why is it ok to know that the implementation of ctx also implements IHyracksTaskContext? -- To view, visit https://asterix-gerrit.ics.uci.edu/605 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa23e9f8a909ddcafc1c3ee95181092eb04ee1ad Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
