abdullah alamoudi has posted comments on this change. Change subject: Add compatibility for Socket adapter ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/609/1/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java: Line 58: throw new AsterixException("Unspecified format parameter for HDFS adapter"); > Is it easy to implement a switch-case-default statement other than if-else I plan on removing this class completely at some point but I am keeping it for now just for compatibility. At some point, this should be deprecated and then removed. Line 84: throw new AsterixException("Unspecified format parameter for local file system adapter"); > Socket adapter? Done Line 87: configuration.put(ExternalDataConstants.KEY_READER_STREAM, ExternalDataConstants.STREAM_SOCKET); > I'm not familiar with Feed configurations, could you explain a bit about wh So previously, we had a bunch of adapters and each of them had a set of configurations embedded within them. so the socket adapter will use the appropriate parser. Now, we have a single adapter and a set of re-usable components. Also, in order to provide better logging and extensibility, our parsers support parsing streams or record objects. the adm parser and the delimited data parsers can parse both streams and records. also, if we have an adm reader, or a line reader, we need to specify the streams for them to use. the stream can come from hdfs, localfs or in this case from a socket -- To view, visit https://asterix-gerrit.ics.uci.edu/609 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c8c78598c0cfea36c18503a73b002ece700be71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
