Taewoo Kim has posted comments on this change. Change subject: Upto threeway fuzzy join based on prefix pruning ......................................................................
Patch Set 11: (7 comments) Please check the comments in a file. It looks like some files are not required in this patch set. https://asterix-gerrit.ics.uci.edu/#/c/530/11/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/ExternalGroupByPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/ExternalGroupByPOperator.java: Line 223: context); Let's remove this file from this patch set since there is no change. https://asterix-gerrit.ics.uci.edu/#/c/530/11/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java: Line 236: * ,the Let's remove this file from this patch set since there is no change. https://asterix-gerrit.ics.uci.edu/#/c/530/11/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorPropertiesUtil.java: Line 40: import org.apache.hyracks.algebricks.core.algebra.operators.logical.NestedTupleSourceOperator; Is this required? If not, let's remove this files from this patch set since there is no change. https://asterix-gerrit.ics.uci.edu/#/c/530/11/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/PlanCompiler.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/PlanCompiler.java: Line 27: import org.apache.commons.lang3.mutable.Mutable; Let's remove this file - PlanCompiler.java - from this patch set since there is no change. https://asterix-gerrit.ics.uci.edu/#/c/530/11/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 37: import org.apache.hyracks.algebricks.core.algebra.base.PhysicalOperatorTag; Is this required? If not, let's remove this file from this patch set since there is no changes in the file. https://asterix-gerrit.ics.uci.edu/#/c/530/11/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/MaterializerTaskState.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/MaterializerTaskState.java: Line 63: MaterializerTaskState.class.getSimpleName()); Let's remove this file from this patch set since there is no changes in the file. https://asterix-gerrit.ics.uci.edu/#/c/530/11/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/SplitOperatorDescriptor.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/misc/SplitOperatorDescriptor.java: Line 83: SPLITTER_MATERIALIZER_ACTIVITY_ID)); Let's remove this file from this patch set since there is no changes in the file. -- To view, visit https://asterix-gerrit.ics.uci.edu/530 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2487078d1821d7ad85bb745bfa31024bcdbea1f1 Gerrit-PatchSet: 11 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Inci Cetindil <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
