abdullah alamoudi has posted comments on this change. Change subject: Support Sending Messages Alongside Frame Data ......................................................................
Patch Set 3: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/604/3/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteOperator.java: Line 53: private final boolean feed; > Why does a Hyracks operator know anything about feeds? Moved to alterJobSpecForFeed https://asterix-gerrit.ics.uci.edu/#/c/604/3/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HashPartitionExchangePOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HashPartitionExchangePOperator.java: Line 51: protected INodeDomain domain; > It seems that these could remain private. Done https://asterix-gerrit.ics.uci.edu/#/c/604/3/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/EnforceStructuralPropertiesRule.java: Line 575: if (op instanceof InsertDeleteOperator && ((InsertDeleteOperator) op).isFeed()) { > If we used operator annotations we could also avoid the instanceof and cast removed completely https://asterix-gerrit.ics.uci.edu/#/c/604/3/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java File hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/IHyracksTaskContext.java: Line 52: public Object getObject(String name); > Could we achieve this with the state object of the IOperatorEnvironment? Using the state of the IOperator environemnt can be done but I believe that it wouldn't be a wise choice. all current methods of the interface will have to be implemented without ever being used. I have removed the redundant methods. Adding it to the IHyracksCommonContext should be fine but the refactoring in the ITupleForwarder is needed since we're just being more specific. https://asterix-gerrit.ics.uci.edu/#/c/604/3/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java File hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/io/MessagingFrameTupleAppender.java: Line 41: public MessagingFrameTupleAppender(IFrame frame, IHyracksTaskContext ctx) throws HyracksDataException { > There seems to be no need for this constructor. Done https://asterix-gerrit.ics.uci.edu/#/c/604/3/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNPartitioningConnectorDescriptor.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNPartitioningConnectorDescriptor.java: Line 49: final PartitionDataWriter hashWriter = new PartitionDataWriter(ctx, nConsumerPartitions, edwFactory, recordDesc, > This variable could be removed. Done https://asterix-gerrit.ics.uci.edu/#/c/604/3/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNPartitioningWithMessageConnectorDescriptor.java File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/connectors/MToNPartitioningWithMessageConnectorDescriptor.java: Line 42: final PartitionWithMessageDataWriter hashWriter = new PartitionWithMessageDataWriter(ctx, nConsumerPartitions, > This variable could be removed. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/604 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56ae8124052c13a52ca42965b8d00e18ecf35a28 Gerrit-PatchSet: 3 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
