Murtadha Hubail has posted comments on this change. Change subject: Support Sending Messages Alongside Frame Data ......................................................................
Patch Set 7: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/605/7/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java File asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitRuntime.java: Line 60: protected IHyracksTaskContext ctx; final https://asterix-gerrit.ics.uci.edu/#/c/605/7/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java: Line 186: Revert https://asterix-gerrit.ics.uci.edu/#/c/605/7/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java: Line 54: ByteBuffer message = null; As we discussed,if possible, remove allocating the message from here and just do it in IngestionRuntime. https://asterix-gerrit.ics.uci.edu/#/c/605/7/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java File asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java: Line 60: if (ctx.getSharedObject() == null) { do this before starting the adapterRuntimeManager thread -- To view, visit https://asterix-gerrit.ics.uci.edu/605 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa23e9f8a909ddcafc1c3ee95181092eb04ee1ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
