Ian Maxon has posted comments on this change. Change subject: Asterix NCs Failback Support ......................................................................
Patch Set 5: Code-Review+1 (9 comments) Minor comments, +1.95 https://asterix-gerrit.ics.uci.edu/#/c/613/5/asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java File asterix-common/src/main/java/org/apache/asterix/common/transactions/LogRecord.java: Line 38: * JobId(4) Update comment Line 67: * 3) UPDATE: 63 + PKValueSize + NewValueSize (5 + 12 + PKValueSize + 20 + 9 + NewValueSize + 8) Let's make this number right Line 108: private boolean replicate = false; s/replicate/replicated/g Line 444: writeLogRecordCommonFields(buffer); Should either remove this whole if block unless there's a way that handleGetRemoteLogs() will give a record of LogType.FLUSH. https://asterix-gerrit.ics.uci.edu/#/c/613/5/asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java File asterix-om/src/main/java/org/apache/asterix/om/util/AsterixClusterProperties.java: Line 511: while (pendingProcessingFailbackPlans.size() > 0) { Use Queue methods here rather than List ones (since it's kind of a queue, even if it is a LinkedList). Line 663: Redundant, above map is complete representation of all plans Line 669: public boolean isMetadataNodeActive() { Should be synchronized Line 684: public JSONObject getClusterStateDescription() throws JSONException { Should also be synchronized https://asterix-gerrit.ics.uci.edu/#/c/613/5/asterix-replication/src/main/java/org/apache/asterix/replication/recovery/RemoteRecoveryManager.java File asterix-replication/src/main/java/org/apache/asterix/replication/recovery/RemoteRecoveryManager.java: Line 328: } See if this can be something less broad than Exception -- To view, visit https://asterix-gerrit.ics.uci.edu/613 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id17819542d6b9c4e32647e64737c4a467b630f24 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
