Yingyi Bu has posted comments on this change. Change subject: Add single-query-wide unique id generator. ......................................................................
Patch Set 7: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/647/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreateQueryUIDDescriptor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreateQueryUIDDescriptor.java: Line 61: // Size: VarLenIntEncoderDecoder.encode(12, ..., ...) bytes, at most 5 bytes. > Since the length is always =(PAYLOAD), the size is always 1 byte? Done Line 74: return new IScalarEvaluator() { > Just a question, when we have multiple inputs do we createScalarEvaluator o We create one per partition. The evaluate method is called once per input tuple. -- To view, visit https://asterix-gerrit.ics.uci.edu/647 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I302f1547c5668250cf4801dbe26ae2aa6f455aa6 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
