Michael Blow has posted comments on this change.

Change subject: Introduce NC to NC Messaging
......................................................................


Patch Set 1:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/657/1/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingClientHandler.java
File 
asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingClientHandler.java:

Line 62:         cause.printStackTrace();
remove printStackTrace()


Line 80:                 future.cause().printStackTrace();
remove printStackTrace()


https://asterix-gerrit.ics.uci.edu/#/c/657/1/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingHandler.java
File 
asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingHandler.java:

Line 41:         System.err.println("channelRead Called");
remove println


Line 47:             System.out.println(buf.readInt());
remove println


Line 54:         cause.printStackTrace();
remove printStackTrace


https://asterix-gerrit.ics.uci.edu/#/c/657/1/asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingServer.java
File 
asterix-app/src/main/java/org/apache/asterix/messaging/NCMessagingServer.java:

Line 69:                     th.printStackTrace();
remove printStackTrace()


https://asterix-gerrit.ics.uci.edu/#/c/657/1/asterix-common/src/main/resources/schema/asterix-conf.xsd
File asterix-common/src/main/resources/schema/asterix-conf.xsd:

Line 62:         
ws


https://asterix-gerrit.ics.uci.edu/#/c/657/1/asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedManager.java
File 
asterix-external-data/src/main/java/org/apache/asterix/external/feed/management/FeedManager.java:

Line 90:             e.printStackTrace();
remove printStackTrace()


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/657
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85bd5ea8ad5b50a6cfb25088d8853f26902799f9
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to