Till Westmann has posted comments on this change. Change subject: Add DDL support for optionally associating meta record with dataset record. ......................................................................
Patch Set 6: Code-Review+1 (4 comments) Looks reasonable to be - usage by Abdullah will show if it is :) https://asterix-gerrit.ics.uci.edu/#/c/666/6/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java: Line 139: boolean hasMeta = dataSource.getMetaItemType() != null; Move this to line 126? https://asterix-gerrit.ics.uci.edu/#/c/666/6/asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta-1/query_dataset_with_meta-5-1.3.query.aql File asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta-1/query_dataset_with_meta-5-1.3.query.aql: Line 19: WS https://asterix-gerrit.ics.uci.edu/#/c/666/6/asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta-2/query_dataset_with_meta-5-2.3.query.aql File asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta-2/query_dataset_with_meta-5-2.3.query.aql: Line 19: WS https://asterix-gerrit.ics.uci.edu/#/c/666/6/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java File asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java: Line 203: } How about bagEncountered = fields1[j].equals("{{"); ? -- To view, visit https://asterix-gerrit.ics.uci.edu/666 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I613316985dbd7f553d946f95c5b1a1df56914902 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
