Till Westmann has posted comments on this change. Change subject: Supprt querying meta record with meta(). ......................................................................
Patch Set 3: (9 comments) Looks good to me, just a few really minor questions. https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: Line 79: LogicalVariable metaVar = allVars.get(allVars.size() - 1); Would it make sense to make the knowledge which position contains which variable part of the DataSourceScanOperator? https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 101: // Adds metea record type if any. typo Line 256: keySourceIndicators.get(i) == 0 ? recordType : metaRecordType); It would be nice, if we could factor the this decision out. Is there a good (single) place to keep the knowledge of the meaning of key source indicators in? https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql File asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta-2.aql: Line 24: create type EmptyType as open { Type is not really empty ... https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql File asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_index_join.aql: Line 24: create type EmptyType as open { Type is not really empty ... https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql File asterix-app/src/test/resources/optimizerts/queries/meta/primary_index_with_meta_self_index_join.aql: Line 24: create type EmptyType as open { Type is not really empty ... https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_failure/query_dataset_with_meta_failure.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_failure/query_dataset_with_meta_failure.1.ddl.aql: Line 24: create type EmptyType as open { Type is not really empty ... https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_primary_index-1/query_dataset_with_meta_primary_index-1.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_primary_index-1/query_dataset_with_meta_primary_index-1.1.ddl.aql: Line 24: create type EmptyType as open { Type is not really empty ... https://asterix-gerrit.ics.uci.edu/#/c/685/3/asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_primary_index-2/query_dataset_with_meta_primary_index-2.1.ddl.aql File asterix-app/src/test/resources/runtimets/queries/meta/query_dataset_with_meta_primary_index-2/query_dataset_with_meta_primary_index-2.1.ddl.aql: Line 24: create type EmptyType as open { Type is not really empty ... -- To view, visit https://asterix-gerrit.ics.uci.edu/685 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65417b6baf209ca0ab413cfa4a5f7fc5156ca63 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
