Yingyi Bu has posted comments on this change. Change subject: Added LeftOuterUnnestMap operator. ......................................................................
Patch Set 5: (4 comments) Are you using the right CodeStyle? I see some files are changed but I reformat them in my Eclipse and couldn't see changes. https://asterix-gerrit.ics.uci.edu/#/c/637/5/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java: Line 434: throw new AlgebricksException("Left-outer-join should propagate all inputs from the outer branch."); "without retainNull and retainInput" --> "without retainInput" https://asterix-gerrit.ics.uci.edu/#/c/637/5/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: Line 490: LeftOuterUnnestMapOperator leftOuterPrimaryIndexUnnestOp = null; Do you need three of those? I guess "UnnestMapOperator primaryIndexUnnestOp" --> "AbstractUnnestMapOperator primaryIndexUnnestOp" probably should be enough. In this way, we leverage the abstraction. Line 541: ArrayList<Mutable<ILogicalExpression>> primaryIndexFuncArgs = new ArrayList<Mutable<ILogicalExpression>>(); ArrayList<Mutable<ILogicalExpression>> primaryIndexFuncArgs --> List<Mutable<ILogicalExpression>> primaryIndexFuncArgs https://asterix-gerrit.ics.uci.edu/#/c/637/5/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 273: .findType(ds.getMetaItemTypeDataverseName(), ds.getMetaItemTypeName()); Are you using the right CodeStyle? http://asterixdb.incubator.apache.org/dev-setup.html -- To view, visit https://asterix-gerrit.ics.uci.edu/637 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6760319c2d3ff90c8b7d8ddeea3d9dd8f743366b Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
